feat: Fix near_network::RoutingTableView::get_announce performance
#5595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmnoxx
force-pushed
the
piotr-fix-get_announce_account
branch
2 times, most recently
from
1d1c77a
to
5db1846
Compare
pmnoxx
changed the title
near_network::RoutingTableView::get_announce performance
pmnoxx
changed the title
near_network::RoutingTableView::get_announce performancenear_network::RoutingTableView::get_announce performance
pmnoxx
force-pushed
the
piotr-fix-get_announce_account
branch
from
5db1846
to
f05a82a
Compare
pmnoxx
added
A-network
mm-near
approved these changes
Dec 8, 2021
mm-near
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading
get_announceimplementation, I noticed that for everyAnnounceAccountread, we were writing it back to disk.Let's simplify
get_announceto avoid additional disk writes.Based on top of #5512
TODO after this PR:
RoutingTableViewTesting:
We have tests for this code